fix(docx): disable numeric coercion of Word text runs - #328
Open
eliziff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent numeric-looking Word text runs from being altered when Mike parses or rewrites DOCX files.
Why / Motivation
fast-xml-parserconverts element text to JavaScript numbers and booleans bydefault. Word stores visible document text in
w:t, so a run containing12.10becomes12.1.This affects text returned by
read_documentand can rewrite an untouched runwhen Mike saves an unrelated tracked edit.
Changes
word/document.xml.Tradeoffs & risks
Element text in
word/document.xmlis now retained as strings, matching howthe DOCX helper consumes it. Attribute parsing, tracked-change IDs, entity
handling, and whitespace behavior are unchanged.
How verified
main, where the rewrittenw:tcontains12.1.12.10through an unrelated trackededit.
npm test --prefix backend— 551 passed, 23 skipped.npm run build --prefix backend.Checklist
.envfiles committed.