-
Notifications
You must be signed in to change notification settings - Fork 0
Initial Release Dev #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MWG-Logan
wants to merge
14
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
46b387f
Refactor services to use constructor injection
MWG-Logan 2a30884
Add Blazor WebAssembly project
MWG-Logan 95bbe1d
Bump Aspire.Hosting.AppHost from 9.3.1 to 9.4.1
dependabot[bot] eb14402
Bump Azure.Identity from 1.14.2 to 1.15.0
dependabot[bot] 5ba92d4
Bump Microsoft.Extensions.ServiceDiscovery from 9.3.1 to 9.4.1
dependabot[bot] 932915d
Bump Microsoft.Extensions.Http.Resilience from 9.4.0 to 9.8.0
dependabot[bot] 0b9c47b
Add terminology section to documentation
MWG-Logan 25e8207
Add target branch for Dependabot updates
MWG-Logan 4009806
Merge pull request #4 from BezaluLLC/dependabot/nuget/Mordos.ServiceD…
MWG-Logan c6857f1
Merge branch 'dev' into dependabot/nuget/Mordos.ServiceDefaults/Micro…
MWG-Logan 24d7468
Merge pull request #3 from BezaluLLC/dependabot/nuget/Mordos.ServiceD…
MWG-Logan fc53a9e
Merge pull request #2 from BezaluLLC/dependabot/nuget/Mordos.API/Azur…
MWG-Logan 49add67
Merge pull request #1 from BezaluLLC/dependabot/nuget/Mordos.AppHost/…
MWG-Logan c805b25
Rename terminology.md to terminology.md
MWG-Logan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Terminology | ||
| >[!WARNING] | ||
| >ROUGH DRAFT! | ||
|
|
||
| * Workload Template = Bicep template defining multiple resources that make up a workload/app, maximally leaning on platform templates. | ||
| * Platform Template = Bicep template defining multiple resources that are to be used by multiple workloads and other deployments. Configurations should be focused on providing centralized services. | ||
| * Resource Template = Bicep template defining an individual resource and how to deploy it. These will typically be included in Mordos, but able to be modified to the MSPs desires. Configurations should be focused on defining best practice and business restrictions for wide-scale (multi-tenant) deployment. | ||
| * Module = Functionality add, typically included by Mordos, but able to be expanded and modified. These are code functions, like name generators and helpers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,4 @@ updates: | |
| directory: "/" # Location of package manifests | ||
| schedule: | ||
| interval: "weekly" | ||
| target-branch: "dev" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Log entries created from user input High
Copilot Autofix
AI 4 months ago
To fix the log forging vulnerability, we need to sanitize any user input before logging it. Since the log entry is plain text and the risk described involves newlines, we should remove carriage return (
\r) and newline (\n) characters from the string before logging. We'll apply this to bothnameFilterandtagFilter, since both are coming from user input and logged. The replacement should be for both possible null or empty values. The best way is to sanitize both variables shortly after extraction, before logging (line 36 or before 37). This fix will not alter the filters passed to the main business logic; it only affects what gets logged. No new methods or dependencies are required; a simple.Replace()(or regex if warranted) is enough.