feat(snap): Snap Store packaging - #4
Merged
Merged
Conversation
Zelfde patroon als de andere OpenAEC-apps: repakt de gepubliceerde release-.deb i.p.v. opnieuw bouwen. Let op: de snapnaam `openaec-installer` is nog niet geregistreerd op snapcraft.io. Belangrijker risico: deze app installeert/start ándere OpenAEC-tools buiten zijn eigen sandbox — dat kan botsen met `confinement: strict`. Zie de PR-omschrijving. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snap/snapcraft.yaml+.github/workflows/snap.yml, same pattern as open-planner-studio: re-packages the already-published release.debinstead of rebuilding, triggered on completion of Build and Release.SNAPCRAFT_STORE_CREDENTIALSis set as a repo secret.openaec-installer.openaec-installeron snapcraft.io — needs to happen before the publish step can do anything.strict-confined snap is sandboxed and generally cannot invoke arbitrary other executables outside its own snap, write anywhere it wants on the filesystem, or manage other installed packages — which may conflict with the installer's core purpose, depending on exactly how it does the installing/launching today (itspackage.json/Cargo.tomlonly declareplugin-opener+plugin-store, so the actual install/launch logic likely lives in custom Rust code I haven't audited). Recommend testing the real installed-snap behavior (not just "does it launch") before publishing tostable— if installing/launching other apps doesn't work under strict confinement,confinement: classicis the alternative, but that requires manual Snap Store review approval on every release (much slower iteration).Test plan
openaec-installeron snapcraft.io.workflow_dispatchtest build against an existing tag (e.g.v0.2.0).SNAPCRAFT_STORE_CREDENTIALS(viasnapcraft export-login --snaps=openaec-installer --channels=stable) and re-run against the real release tag to publish.confinement: classicbefore publishing further.🤖 Generated with Claude Code