fix(api): serve SPA when installed via pip#16
Open
pritambiswal wants to merge 1 commit into
Open
Conversation
After `pip install .` api.py runs from site-packages, so
Path(__file__).parent.parent.parent / "static" resolves to
<site-packages parent>/static (e.g. /usr/local/lib/python3.12/static)
which doesn't exist. The Dockerfile copies the built frontend to
/app/static, so the StaticFiles mount silently no-ops and every
non-API URL returns FastAPI's default {"detail": "Not Found"}.
Honour an OPENAEC_STATIC_DIR env override and fall back to the old
source-tree-relative path so `python -m uvicorn` from the repo root
still works in dev. Dockerfile pins it to /app/static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
pip install .,api.pyruns from site-packages soPath(__file__).parent.parent.parent / "static"no longer points at/app/static. The mount silently no-ops and every non-API URL returns FastAPI's default 404.Adds an
OPENAEC_STATIC_DIRenv override (Dockerfile pins it to/app/static), falls back to the old relative path so in-place dev runs still work.