Skip to content

False positive diff for array with maxItems fix #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

False positive diff for array with maxItems fix #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
702673e
False positive diff for array with maxItems fix
DrSatyr May 13, 2025
2387e6a
fix: correct comparison logic in ChangedMaxItems and ChangedMinItems
DrSatyr May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMaxItems.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.openapitools.openapidiff.core.model.schema;

import java.util.Objects;
import org.openapitools.openapidiff.core.model.Changed;
import org.openapitools.openapidiff.core.model.DiffContext;
import org.openapitools.openapidiff.core.model.DiffResult;
Expand All @@ -17,7 +18,7 @@ public ChangedMaxItems(Integer oldValue, Integer newValue, DiffContext context)

@Override
public DiffResult isChanged() {
if (oldValue == newValue) {
if (Objects.equals(oldValue, newValue)) {
return DiffResult.NO_CHANGES;
}
if (oldValue == null || newValue == null) {
Expand Down
3 changes: 2 additions & 1 deletion core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMinItems.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.openapitools.openapidiff.core.model.schema;

import java.util.Objects;
import org.openapitools.openapidiff.core.model.Changed;
import org.openapitools.openapidiff.core.model.DiffContext;
import org.openapitools.openapidiff.core.model.DiffResult;
Expand All @@ -17,7 +18,7 @@ public ChangedMinItems(Integer oldValue, Integer newValue, DiffContext context)

@Override
public DiffResult isChanged() {
if (oldValue == newValue) {
if (Objects.equals(oldValue, newValue)) {
return DiffResult.NO_CHANGES;
}
if (oldValue == null || newValue == null) {
Expand Down