Skip to content

chore(feature): skip search by default #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(feature): skip search by default #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,15 @@ jobs:
(npm run oa version-manager set 4.0 && npm run oa version | grep -q '4.0.3') || exit 1
(npm run oa version-manager set 4.3.1 && npm run oa version | grep -q '4.3.1') || exit 1
(npm run oa version-manager set 4.3.1 && npm run oa version | grep -q '4.3.1') || exit 1
(export OPENAPI_GENERATOR_CLI_SEARCH_URL=DEFAULT && npm run oa version-manager set 7.2.0 && npm run oa version | grep -q '7.2.0') || exit 1
json -I -f openapitools.json -e 'this["generator-cli"]["storageDir"]="./my/storage/"'
(npm run oa version-manager set 4.3.0 && npm run oa version | grep -q '4.3.0') || exit 1
test -f ./my/storage/4.3.0.jar || exit 1
json -I -f openapitools.json -e 'this["generator-cli"]["storageDir"]="~/my/storage/"'
(npm run oa version-manager set 4.3.1 && npm run oa version | grep -q '4.3.1') || exit 1
test -f ~/my/storage/4.3.1.jar || exit 1
npm run oa:generate && mkdir ./foo && cd ./foo && npm run oa:generate
(export OPENAPI_GENERATOR_CLI_SEARCH_URL=MAVEN && npm run oa version-manager set 7.2.0 && npm run oa version | grep -q '7.2.0') || exit 1


# release:
# if: github.event.pull_request.merged == 'true'
Expand Down
2 changes: 1 addition & 1 deletion apps/generator-cli/src/app/services/version-manager.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class VersionManagerService {

getAll(): Observable<Version[]> {
// bypass querying serach.maven.org and use default versions instead
if (process.env.OPENAPI_GENERATOR_CLI_SEARCH_URL === 'DEFAULT' ) {
if (process.env.OPENAPI_GENERATOR_CLI_SEARCH_URL !== 'MAVEN' ) {
return this.getObservableVersions();
}

Expand Down
Loading