Skip to content

Conversation

@dsteeley
Copy link
Contributor

In the rust-server generator we used the re-export of Authorization from src/server.rs rather than directly using swagger::auth::Authorization. This caused compilation errors when compiling an autogenerated crate with --no-default-features. To resolve I've updated the references to crate::server::Authorization to swagger::auth::Authorization.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dsteeley dsteeley force-pushed the fixup_no_default_features branch from 3f44113 to cb0bee5 Compare November 26, 2025 15:37
@wing328
Copy link
Member

wing328 commented Nov 27, 2025

thanks for the pr

can you please review the build failure when you've time?

@dsteeley dsteeley force-pushed the fixup_no_default_features branch from cb0bee5 to 02ef6ed Compare November 27, 2025 08:40
@dsteeley dsteeley force-pushed the fixup_no_default_features branch from 02ef6ed to e3b694f Compare November 27, 2025 09:42
@dsteeley
Copy link
Contributor Author

thanks for the pr

can you please review the build failure when you've time?

Resolved, thanks for flagging.

@wing328 wing328 merged commit 453997b into OpenAPITools:master Nov 30, 2025
18 checks passed
@wing328 wing328 added this to the 7.18.0 milestone Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants