fix(groq): honor model kwarg in generate_with_usage response metadata#207
Open
syf2211 wants to merge 1 commit into
Open
fix(groq): honor model kwarg in generate_with_usage response metadata#207syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Fixes OpenAgentHQ#79 generate_with_usage() already sent the per-request model override in the API payload but LLMResponse.model always used self.model. Use the resolved request model so evaluation pipelines and cost trackers attribute responses correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Groq.generate_with_usage()already sent the per-requestmodeloverride in the API payload but always reportedself.modelin the returnedLLMResponse. This fix uses the resolved request model so response metadata matches the model actually used.Type of Change
Related Issues
Closes #79
How Has This Been Tested?
pytest tests/unit/test_providers/test_groq.py -v— 18 passed)ruff checkon groq.py and test_groq.py)uv run mypy openagent_eval/)Checklist
Additional Notes
One-line behavioral fix in
groq.py; follows the model-override testing pattern fromtest_ollama.py.