Skip to content

fix(nli): return 1.0 for empty claims in score_faithfulness #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himanshu231204 merged 2 commits into from
Jul 22, 2026
+2 −2
Merged

fix(nli): return 1.0 for empty claims in score_faithfulness #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49c96be
fix(nli): return 1.0 for empty claims in score_faithfulness
syf2211 Jul 22, 2026
465a84b
Merge branch 'main' into fix/evidence-finder-empty-claims-score
himanshu231204 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openagent_eval/metrics/nli/evidence_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def score_faithfulness(
Tuple of (faithfulness_score, list_of_matches).
"""
if not claims:
return 0.0, []
return 1.0, []

matches = self.find_evidence_batch(claims, contexts)
supported = sum(
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_metrics/test_nli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def test_score_faithfulness_none_supported(self):

def test_score_faithfulness_empty_claims(self):
score, matches = self.finder.score_faithfulness([], ["context"])
assert score == 0.0
assert score == 1.0
assert matches == []


Expand Down
Loading