Fixed JSONL max_documents cumulative cap#237
Merged
Merged
Conversation
Co-authored-by: himanshu231204 <himanshu231204@users.noreply.github.com>
Member
|
/oc resolve merge conflict |
Use slicing (documents[:self.max_documents]) instead of in-place delete (del documents[self.max_documents:]) to match the fix already merged in PR #230.
Contributor
Author
|
The merge conflict in No diff remains between this branch and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint warnings are pre-existing and unrelated to the change.
Fix summary: In
openagent_eval/corpus/auditor.py:195-203, theif len(documents) >= self.max_documents: breakcheck was inside theelse(non-JSONL) branch, so after processing a.jsonlfile viadocuments.extend(...)the cumulative cap was never evaluated. Fixed by:del documents[self.max_documents :]to truncate on overshoot (needed when_load_jsonl_documentsreturns its local cap ofmax_documentsbutdocumentsalready has items from prior files).All 65 corpus tests pass.
Closes #224
opencode session | github run