Fix stale token balance reads after Sepolia minting - #1
Draft
mingyech wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Sepolia deposit could stop with “the balance is still too low” immediately after its test-token mint succeeded, because MetaMask’s
latesttoken-balance read still reflected the previous block. Read the balance at the mint receipt’s block, verify that block remains canonical and the wallet remains on the configured network, and retry lagging reads for a bounded period without submitting another mint.Validation: all 193 SDK tests pass, including the actual deposit path with the reproduced 4.992540 → 5.000000 balance transition, lagging reads, reorgs, network changes, invalid receipts, and bounded retry exhaustion. Independent review found no blocking issues. The original error was reproduced in the deployed Sepolia Commercial app and its successful mint was verified on-chain; verification of the patched deployment is in progress.