chore: cleanup build warnings #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the trivial build warnings. A couple of dead-code warnings remain, which seem useful as build-time warnings so they get resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm not sure if you are ready to accept PRs or not, but this is just a simple cleanup of some build warnings that hopefully you will find an improvement. I'm glad to see openbazaar development resume, and in rust no less! 👍
--
This fixes the trivial build warnings.
note: I removed
usestatements that are unused, but I left commented anything that I found referenced in commented code below.A couple of dead-code warnings remain, which seem useful as build-time warnings so they get resolved. So I did not #[allow(dead_code)].