Skip to content

Add len and count rate methods to flash loader #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2025
Merged

Add len and count rate methods to flash loader #564

merged 4 commits into from
Aug 28, 2025

Conversation

zain-sohail
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Mar 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17294184254

Details

  • 24 of 39 (61.54%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 91.977%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sed/loader/flash/loader.py 24 39 61.54%
Totals Coverage Status
Change from base Build 17269494241: -0.09%
Covered Lines: 8277
Relevant Lines: 8999
💛 - Coveralls

@zain-sohail
Copy link
Member Author

zain-sohail commented Mar 28, 2025 •
edited
Loading

  • add sp.info to show the metadata

@zain-sohail zain-sohail requested a review from Copilot April 6, 2025 16:11
Copilot
Copilot AI reviewed Apr 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • .cspell/custom-dictionary.txt: Language not supported

@Aserhisham Aserhisham merged commit 02bd061 into main Aug 28, 2025
5 checks passed
@Aserhisham Aserhisham deleted the count_rate_flash branch August 28, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Aserhisham Aserhisham Aserhisham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zain-sohail @coveralls @Aserhisham