Skip to content

[client] now use internal id when possible for patch operations #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Apr 24, 2025

Proposed changes

  • use internal_id for patch operation instead of standard_id, to handle patches that cause a standard_id change

related opencti PR: OpenCTI-Platform/opencti#10825

Related issues

  • opencti #10817

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Apr 24, 2025
@JeremyCloarec JeremyCloarec added multi-repository When a PR requires several repository changes and removed filigran team use to identify PR from the Filigran team labels Apr 24, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Apr 24, 2025
@JeremyCloarec JeremyCloarec merged commit 1740204 into master Apr 25, 2025
7 checks passed
@JeremyCloarec JeremyCloarec deleted the opencti/issue/10817 branch April 25, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team multi-repository When a PR requires several repository changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants