Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch instantiation errors on checks #23

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Catch instantiation errors on checks #23

merged 2 commits into from
Jun 17, 2024

Conversation

parijke
Copy link
Contributor

@parijke parijke commented Jun 15, 2024

This PR wraps the check chain in a try / catch block to catch check instantiation errors

@parijke parijke requested review from pmeulen and MKodde June 15, 2024 09:51
MKodde
MKodde approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution. It is a slight change in behavior. I do not think that should disrupt any other applications, but only improve things.

src/Controller/HealthController.php Outdated Show resolved Hide resolved
@parijke parijke changed the title Catch compile errors on checks Catch instantiation errors on checks Jun 17, 2024
@parijke parijke merged commit efcb68f into main Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKodde MKodde MKodde approved these changes

@pmeulen pmeulen Awaiting requested review from pmeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parijke @MKodde