Upgrade Spomky webauthn dependencies #175
Open
+386
−1,730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/upgrade-webauthn-library
branch
6 times, most recently
from
76d410a to
ea71576
Compare
pablothedude
force-pushed
the
feature/upgrade-webauthn-library
branch
from
ea71576 to
f84595d
Compare
Also removed the custom internal controller logic. So when the Webauthn flow is started it will be completely handled by the bundle and the configuration can be used without hassle.
pablothedude
force-pushed
the
feature/upgrade-webauthn-library
branch
from
f84595d to
aca0dea
Compare
johanib
reviewed
Feb 25, 2025
| $nameId = $event->getUser()->name; | ||
| $logger = WithContextLogger::from($this->logger, ['nameId' => $nameId]); | ||
|
|
||
| if ($routeName == 'webauthn.controller.security.main.creation.result') { |
There was a problem hiding this comment.
Possible to use constant? (also in twig)
| $this->write("<info>Migating: {$id}</info>"); | ||
|
|
||
| $transports = json_encode(unserialize($transports), JSON_THROW_ON_ERROR); | ||
| $otherUi = json_encode(unserialize($otherUi), JSON_THROW_ON_ERROR); |
There was a problem hiding this comment.
How resilient should this migration be?
If we're talking about a couple of thousand rows, this is fine.
If millions, maybe catch the exception and continue, so it can continue where it left off if the first attempt to migrate everything fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the custom internal controller logic.
So when the Webauthn flow is started it will be
completely handled by the bundle and the configuration
can be used without hassle.