Make Symfony 7.4 compatible #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove deprecated phpcpd
AttributeToAttributeRector ReadOnlyPropertyRector TypedPropertyRector MixedTypeRector
MKodde
requested changes
Jan 27, 2026
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
I'm reluctant to approve this PR. Mainly on account of my second comment where you slightly changed the StateHandler behavior.
Secondly. I suggest you wait with merging this PR once a new tag is released of the SAML bundle with the SF 7.4 support. That way you can immediately get rid of the dev dependency in your composer.json
MKodde
approved these changes
Jan 29, 2026
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Approved on account of you dotting the last i's
johanib
force-pushed
the
feature/update
branch
from
e667625 to
4053d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.