Improve timeouts during registration/authentication polling #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is added to isolate the timeout 'business' rules are implemented correctly. And make them testable.
MKodde
force-pushed
the
feature/polling-timeout
branch
from
b7afcc5
to
49de216
Compare
MKodde
commented
Sep 12, 2024
| // Effectively this does a $this->_stateStorage->getValue(self::PREFIX_CHALLENGE . $sessionKey); | ||
| // To check that the session key still exists in the Tiqr_Service's state storage | ||
| try { | ||
| $this->tiqrService->authenticationUrl(); |
There was a problem hiding this comment.
This is the old logic, the story mentions. I opted to stop applying this method of testing for timeouts. And simply apply the same timeout check I added for the enrollment (registration) logic.
MKodde
force-pushed
the
feature/polling-timeout
branch
from
c17b73a
to
2db1d4b
Compare
The Jest test was not yet covering the possibility of a registration timeout
MKodde
force-pushed
the
feature/polling-timeout
branch
from
2db1d4b
to
5156186
Compare
mharte-ib
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While polling for authn/registration state changes. The globally defined timeout periods for these actions where not tested explicitly. This PR ensures we start testing if the timeout period is expired.
For registration, I added a new timeout error page. For this a new translation was added @pmeulen do you agree with my proposed translations? If not feel free to suggest better ones. I based these off the authn ones.
An offset time is substracted from the hard timeout time. This makes the timeout occur a couple of seconds before the actual timeout would take place. This prevents user actions taking place right before expiration time from erroring.
See: https://www.pivotaltracker.com/story/show/188205272 (note that the story mentions registration/authentication sessions. These are not to be confused with state/php sessions. But they are the 'session' in which an authentication or a registration takes place.)