-
-
Notifications
You must be signed in to change notification settings - Fork 11
DSDLDefinition: do not resolve symlink #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Remove path resolution
Have you ascertained that this change alone is sufficient to make it work with Bazel? Symlink resolution is not essential for PyDSDL, but path canonicalization is, so that should be introduced instead. |
@pavel-kirienko to be honest, I didn't do a deep investigation of every possible Bazel use case, but just the minimal changes to make my specific case work: Also, if you will ever be interested in adding Bazel support to dsdl C++ code generation, let me know as I can share some Bazel code that can serve as starting point. |
@thirtytwobits is this going to break anything on your side? |
Yes. This was added to fix #111 |
@filippobrizzi , can you provide an example for how this code fails when the path includes a symlink? |
Is this really about symlinks or are we asking to allow relative paths to be canonical? |
@filippobrizzi nudge |
Hi @pavel-kirienko, I wanted to provide an example on how it could be used with Bazel, but didn't have the time. I will try in the next days |
Remove path resolution for files.
To make
pydsdl
work with Bazel we need to allow it to work with symlinks as Bazel works with sandbox environments.