refactor: route supervisor workflow events through chat#501
Merged
shuxueshuxue merged 1 commit intomainfrom May 6, 2026
Merged
refactor: route supervisor workflow events through chat#501shuxueshuxue merged 1 commit intomainfrom
shuxueshuxue merged 1 commit intomainfrom
Conversation
Collaborator
Author
Additional YATU EvidenceRan a real product-path YATU on the macmini in an isolated Artifact: Flow covered:
Key evidence:
The first harness assertion had a wrong log path ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routes supervisor workflow-originated events through the same Mycel backend chat delivery path as normal durable messages.
This removes the remaining content-bearing local terminal hint path from
notify_supervisor. Terminal surface delivery remains only for explicit wake controls and backend notification hints.Architecture Notes
notify_supervisor(group, message)now sends an addressed chat message to the supervisor user.enforce_caught_up=Falseis used only for this workflow-originated event path because it is a runtime workflow event, not a human/agent conversational send that should be blocked by read-before-send.cel group ... supervisor wakestill uses direct surface wake because that command is explicitly a wake control, not a durable chat message.Verification
uv run ruff check .uv run ruff format --check .uv run pytest tests/test_group_chat_transport.py -quv run pytest -q-> 468 passedFollow-up Boundary
This PR does not change backend message typing. The current public send API still records this as the backend's existing send-message type. If workflow message typing needs to become first-class, that should be a backend API primitive rather than CLI-side special casing.