Skip to content

refactor: share workflow addressed sends#503

Merged
shuxueshuxue merged 1 commit intomainfrom
fix/workflow-notify-shared-send
May 6, 2026
Merged

refactor: share workflow addressed sends#503
shuxueshuxue merged 1 commit intomainfrom
fix/workflow-notify-shared-send

Conversation

@shuxueshuxue
Copy link
Copy Markdown
Collaborator

Summary

  • route group workflow notifications through the shared addressed message sender
  • remove warning-only swallowed send failures from workflow notify loops
  • add boundary tests that prevent direct workflow chat sends and swallowed send errors

Verification

  • uv run pytest tests/test_boundary.py::test_group_workflow_notify_does_not_send_chat_directly tests/test_boundary.py::test_group_workflow_notify_does_not_swallow_send_errors tests/test_group_chat_transport.py tests/test_daemon_subscriber.py tests/test_daemon_ipc.py -q
  • uv run pytest -q
  • uv run ruff check packages/mycel-cli/src tests/test_boundary.py
  • uv run ruff format --check packages/mycel-cli/src tests/test_boundary.py

@shuxueshuxue shuxueshuxue merged commit ad028c7 into main May 6, 2026
5 checks passed
@shuxueshuxue shuxueshuxue deleted the fix/workflow-notify-shared-send branch May 6, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant