Skip to content

Issue 1439 Fix #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tazmeenahhmed wants to merge 7 commits into
base: development
Choose a base branch
from
+221 −230
Open

Issue 1439 Fix #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ba11c7
added areaUnit and readingFrequency to expectMetersToBeEquivalent to …
tazmeenahhmed Jan 13, 2026
cc26117
Added a test to meters.js that checks if converUnitValue returns -99 …
tazmeenahhmed Jan 31, 2026
bbe9554
added two tests to check that insert() and update() return the correc…
tazmeenahhmed Feb 13, 2026
cb75be4
Rolled tests from meterTests.js into meters.js and removed meterTests.js
tazmeenahhmed Mar 6, 2026
282f389
added a functions that checks getByIdentifier and getAll methods with…
tazmeenahhmed Mar 6, 2026
f1b6a17
Removed compareMeters frome csvPipelineTest and replaced with an impo…
tazmeenahhmed Mar 13, 2026
77b4f86
Merge branch 'OpenEnergyDashboard:development' into metertestcode
tazmeenahhmed Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/models/Meter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Unit = require('./Unit');
const { log } = require('../log');
const sqlFile = database.sqlFile;

class Meter {
class Meter {
Copy link
Copy Markdown
Member

@huss huss Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space added to the end of this line. OED prefers not to do that and this is the only change in the file. Could you undo this so no changes are shown in the file.

/**
* @param id This meter's ID. Should be undefined if the meter is being newly created
* @param name This meter's name
Expand Down
182 changes: 0 additions & 182 deletions src/server/test/db/meterTests.js
View file
Open in desktop

This file was deleted.

47 changes: 3 additions & 44 deletions src/server/test/web/csvPipelineTest.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading