Fix: LR14 expected value#1626
Merged
Merged
Conversation
Initialize LR17
…C_gu_Widget_st_-inf_et_inf.csv
huss
reviewed
May 21, 2026
|
|
||
| // Add LR17 here | ||
|
|
||
| mocha.it('LR22: range should have hourly points for middle readings of 15 minute for a 60 day period and raw units & C as F with intercept', async () => { |
Member
There was a problem hiding this comment.
I'm unsure why the line above that had // Add LR22 here is listed as deleted in this PR since I don't see that line in the current development branch. However, it should not be there so this is simply a comment about it.
huss
approved these changes
May 21, 2026
Member
huss
left a comment
huss
left a comment
There was a problem hiding this comment.
@Angel43v3r & @OrgitoV Thank you for this PR. Review and testing found it is fine. For the record, I'm noting that this currently does not change the test behavior since preferred display of units are not yet implemented but it is good to have this correct in case a future change would have caused an issue. Congratulations on another accepted contribution to OED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On test case LR14, u6 preferredDisplay was set to false. In the #962 , the expected value for u6 preferredDisplay is true.
Updated preferredDisplay: false -> preferredDisplay: true
Contributors:
@Angel43v3r
@OrgitoV
Partly Addresses #962
Type of change
Checklist
Limitations
No issues known