Reduce optimization level for FAST*_Types.f90 with gcc #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deslaughter
approved these changes
Feb 12, 2025
|
Backport to 4.1.0 if we do such a release before 5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Compiling in release with GCC takes a very long time due to unnecessary optimization of the
FAST_Types.f90andFAST_Farm_Types.f90files. These files contain a fair amount of code related to save/restore used in restarts, which really doesn't need to be all that optimized given the frequency of use.Some time ago we benchmarked the build process with
-O2and-O3onFAST_Types.f90and found that the majority of the build time in that file was spent on the save/restore routines (tested with Intel OneAPI on linux). Reducing to-O2reduced the compile time significantly in that case.Related issue, if one exists
Can't find the first PR.
Impacted areas of the software
Build process with GCC. May be slight performance hit on save/restore with GCC compiled executables, but no other effects expected.