Skip to content

Fix lint errors and suppress generated-bundle lint noise#13

Merged
aliamerj merged 1 commit into
mainfrom
codex/fix-lint-errors-and-warnings
Apr 2, 2026
Merged

Fix lint errors and suppress generated-bundle lint noise#13
aliamerj merged 1 commit into
mainfrom
codex/fix-lint-errors-and-warnings

Conversation

@aliamerj

@aliamerj aliamerj commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • Resolve lint-blocking issues reported by eslint so lint exits successfully without introducing behavior changes.
  • Reduce thousands of non-actionable warnings coming from a generated bundle so real issues are easier to spot.

Description

  • Move global comment scroll handler into a useEffect with cleanup to satisfy immutability rules in components/FeatureDetail/CommentsContainer.tsx.
  • Remove unnecessary mount-state effect from components/FromatDistanceToNow/FormatDistanceToNow.tsx so we avoid set-state-in-effect warnings while preserving output.
  • Replace a manual memoized callback with a direct lookup for author role in components/RenderComment/RenderComment.tsx to avoid React Compiler memoization warnings.
  • Fix useMemo dependency list by adding projectId in components/WidgetPreview/WidgetPreview.tsx.
  • Simplify PaymentContext to provide paddlePay inline and remove problematic memoization assumptions in contexts/PaymentContext.tsx.
  • Convert getUserRole to a stable useCallback and update dependent callbacks in contexts/ProjectPermissionProvider.tsx.
  • Update tailwind.config.js to use an ESM import for typography and export a named config object to satisfy lint rules.
  • Ignore the generated bundle public/packages/widget.iife.js in eslint.config.mjs to eliminate thousands of non-actionable warnings.

Testing

  • Ran npm run lint after the changes and the command now completes successfully with 0 errors and only non-blocking warnings (lint exit code 0).
  • No other automated tests were modified or required for these changes.

Codex Task

@aliamerj aliamerj merged commit 054ad68 into main Apr 2, 2026
2 checks passed
@aliamerj aliamerj deleted the codex/fix-lint-errors-and-warnings branch April 2, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant