Fix lint errors and suppress generated-bundle lint noise#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
eslintso lint exits successfully without introducing behavior changes.Description
useEffectwith cleanup to satisfy immutability rules incomponents/FeatureDetail/CommentsContainer.tsx.components/FromatDistanceToNow/FormatDistanceToNow.tsxso we avoidset-state-in-effectwarnings while preserving output.components/RenderComment/RenderComment.tsxto avoid React Compiler memoization warnings.useMemodependency list by addingprojectIdincomponents/WidgetPreview/WidgetPreview.tsx.PaymentContextto providepaddlePayinline and remove problematic memoization assumptions incontexts/PaymentContext.tsx.getUserRoleto a stableuseCallbackand update dependent callbacks incontexts/ProjectPermissionProvider.tsx.tailwind.config.jsto use an ESM import for typography and export a named config object to satisfy lint rules.public/packages/widget.iife.jsineslint.config.mjsto eliminate thousands of non-actionable warnings.Testing
npm run lintafter the changes and the command now completes successfully with0errors and only non-blocking warnings (lint exit code 0).Codex Task