Repository navigation
Fix index map label rendering; render index map tab first - #237
Merged
Merged
Conversation
This fixes a bug where some index maps would show the polygon labels repeated many times, because of the way that MapLibre picks locations to render text labels: it renders one for every disjoint polygon in a MultiPolygon, as well as every time a polygon crosses a tile boundary. This creates our own logic that picks the largest single part of a multipolygon to use as the host for a label for the group, so that index maps don't end up with crowded, duplicate labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label polygons in index maps only once, at a sensible location
This fixes a bug where some index maps would show the polygon
labels repeated many times, because of the way that MapLibre picks
locations to render text labels: it renders one for every disjoint
polygon in a MultiPolygon, as well as every time a polygon crosses
a tile boundary.
This creates our own logic that picks the largest single part of
a multipolygon to use as the host for a label for the group, so
that index maps don't end up with crowded, duplicate labels.
Make index maps render before PMTiles in tab order