Prevent unhandled errors when the component redraws after unmounting #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the map component unmounts, it is possible for the
redraw()method to be called when there is no longer a map element. For example:This PR is a trivial change that checks for
map._mapPaneexisting before callingmap._getMapPanePos()which triggers the unhandled exception.Both the
src/andlib/versions have been updated, the patch version has been bumped, linting passes except for in theexample/directory where it was already failing, the code is tested and working, and I certify that the terms set out under "Developer's Certificate of Origin 1.1" are met by this contribution.