DRAFT: improving reliability with security analyzer #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create SecurityPromptEvent class similar to SystemPromptEvent - Add security_prompt to EventType literal in types.py - Export SecurityPromptEvent through __init__.py files - Create security_analyzer_info.j2 template for security guidance - Modify Agent.init_state() to add SecurityPromptEvent when security analyzer enabled - Modify View.from_events() to conditionally include SecurityPromptEvent - Add comprehensive tests for SecurityPromptEvent functionality Co-authored-by: openhands <[email protected]>
…meter - Add is_security_analyzer_enabled parameter to View.from_events() method - Update SecurityPromptEvent filtering logic to use parameter instead of event presence detection - Modify Agent.init_state() to always add SecurityPromptEvent when template is available - Update all call sites of View.from_events() to pass the security analyzer parameter - Add comprehensive test for the new parameter-based filtering logic - Ensure consistent security filtering in both condenser and non-condenser code paths Co-authored-by: openhands <[email protected]>
Contributor
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Since is_security_analyzer_enabled defaults to False in View.from_events(), the explicit False parameters are redundant and can be removed for cleaner code. Only explicit True values are needed when security analyzer is enabled. Co-authored-by: openhands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed solution
@malhotra5 can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:263245b-pythonRun
All tags pushed for this build
About Multi-Architecture Support
263245b-python) is a multi-arch manifest supporting both amd64 and arm64263245b-python-amd64) are also available if needed