Enable Ruff checks for mutable defaults (B006, B008, B039, RUF012) #1055
+42
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add extend-select to enable flake8-bugbear rules B006, B008, B039 and Ruff RUF012 - These catch mutable defaults in function args, default-call patterns, ContextVar defaults, and mutable class attributes Co-authored-by: openhands <[email protected]>
Contributor
Coverage Report •
|
||||||||||||||||||||||||||||||
- Add fastapi.Depends and fastapi.params.Depends to flake8-bugbear extend-immutable-calls - This keeps B008 enabled while ignoring the idiomatic FastAPI pattern Co-authored-by: openhands <[email protected]>
- Change file: UploadFile = File(...) -> file: Annotated[UploadFile, File(...)] - Removes the last non-Depends B008 while preserving FastAPI semantics Co-authored-by: openhands <[email protected]>
- Change default list params to Optional and coalesce to [] inside - Ensures no shared mutable defaults, keeps behavior identical for callers Co-authored-by: openhands <[email protected]>
…needed - Use Field(default_factory=...) for lists/dicts in tests - Switch VisualizerCustomAction.task_list to default_factory - Add pydantic.Field imports in affected tests Co-authored-by: openhands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable Ruff rules that catch mutable default pitfalls:
Changes
Context
Motivated by a review thread on the visualization API discussing mutable defaults. On main, our Ruff config selected only E, F, I, UP, ARG. Pre-commit and CI therefore did not flag these cases.
Impact
A local run surfaced:
Follow-ups
Closes: #1054
Co-authored-by: openhands [email protected]
@enyst can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:6ef3209-pythonRun
All tags pushed for this build
About Multi-Architecture Support
6ef3209-python) is a multi-arch manifest supporting both amd64 and arm646ef3209-python-amd64) are also available if needed