Use shell:bash in run-examples workflow #1057
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Ray's suggestion to use
shell: bashin the GitHub Actions workflow for running examples. This ensures that failures won't get masked by automatically applyingset -euo pipefail.Changes
shell: bashto the "Run examples" step: This is the main long-running script that tests all examples with a real LLMset -e: Sinceshell: bashautomatically appliesset -euo pipefail(which includes-eplus additional safety flags), the explicitset -eis no longer neededshell: bashto the "Read examples report" step: For consistency and safety in bash script executionBenefits
-eflag ensures the script exits on any command failure-uflag treats unset variables as errors-o pipefailoption ensures that failures in piped commands are not maskedContext
From the conversation thread, Ray noted:
This change follows that best practice recommendation.
Testing
Co-authored-by: openhands [email protected]
@xingyaoww can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:92d13d3-pythonRun
All tags pushed for this build
About Multi-Architecture Support
92d13d3-python) is a multi-arch manifest supporting both amd64 and arm6492d13d3-python-amd64) are also available if needed