Skip to content

Added default resolution and corrected exposure for default 60fps#1814

Merged
viktorxda merged 1 commit into
OpenIPC:masterfrom
MarioFPVdev:patch-14
Jul 4, 2025
Merged

Added default resolution and corrected exposure for default 60fps#1814
viktorxda merged 1 commit into
OpenIPC:masterfrom
MarioFPVdev:patch-14

Conversation

@MarioFPVdev

Copy link
Copy Markdown
Member

Added default resolution
Added default gop
Corrected exposure for default 60fps

Added default resolution
Added default gop
Corrected exposure for default 60fps

@flyrouter flyrouter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions, they will be discussed soon.

@snokvist

Copy link
Copy Markdown
Contributor

To handle sensor variants, this change will be proposed in /usr/bin/wifibroadcast for sbc 2.0 release in 2-3 weeks.

Setting a static resolution without checking for sensor type will otherwise force the wrong ratio.
Gop could be appended

video_settings() {
sensor=$(ipcinfo -s)
cli -s .isp.sensorConfig /etc/sensors/"$sensor"_fpv.bin
cli -s .isp.exposure 16
cli -s .video0.fps 60
cli -s .video0.bitrate 8192
cli -s .video0.codec h265
cli -s .video0.rcMode cbr
cli -s .outgoing.enabled true
cli -s .outgoing.wfb true
cli -s .fpv.enabled true
cli -s .fpv.noiseLevel 1
if [ "$sensor" = "imx335" ]; then
cli -s .video0.size 1440x1080
else
cli -s .video0.size 1920x1080
fi
}

@MarioFPVdev

Copy link
Copy Markdown
Member Author

Currency the static resolution of the Thinker Tiny is 704x576. I don't know why, you may ask Dmitry or Viktor.

I also agree that the default resolution should be defined based on the sensor but for the time being it should be 1920x1080 since all the bin file sensors have been calibrated based on that resolution.

The 1440x1080 resolution will require different bin files for good video quality. I have tested the 4:3 1440x1080 resolution with the imx335 Thinker Tiny with the existing sensor bin files and the video was overexposed. It was also in box view on a 16:9 resolution monitor. The bin files in 1920x1080 resolution was fine as we would expect.

@flyrouter

flyrouter commented May 12, 2025

Copy link
Copy Markdown
Member

Also discussion here - https://t.me/c/1809358416/28287/218235
OpenIPC FPV chat in Telegram, link found in our site

@MarioFPVdev MarioFPVdev deleted the patch-14 branch May 13, 2025 20:17
@MarioFPVdev MarioFPVdev restored the patch-14 branch June 4, 2025 15:45
@MarioFPVdev MarioFPVdev reopened this Jun 4, 2025
@MarioFPVdev

Copy link
Copy Markdown
Member Author

To handle sensor variants, this change will be proposed in /usr/bin/wifibroadcast for sbc 2.0 release in 2-3 weeks.

Is this proposal now included in the SBC 2.0?

@MarioFPVdev MarioFPVdev requested a review from flyrouter June 7, 2025 10:52
@viktorxda viktorxda merged commit 44f1b66 into OpenIPC:master Jul 4, 2025
84 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants