hisilicon-osdrv-hi3519v101: fix IMX385 sensor config for real hardware - #2011
Merged
Conversation
Default imx385_i2c_1080p.ini ships values that don't work for a real IMX385 rig on hi3519v101. On a Hi3516AV200 DEMO board with a 4-lane MIPI IMX385 running 1080p60 linear, the stock ini produced no valid sensor output (sensor bring-up uses 10-bit RAW + 25fps + cropped VI frame) while the .so exports the object as stSnsImx385Obj, not the generic stSnsObj the ini referenced. Changes (from the camera's known-good /etc/sensors/imx385_i2c_1080p.ini): Sensor_type stSnsObj -> stSnsImx385Obj Mode WDR_MODE_NONE -> 0 (numeric form the parser reads) data_type RAW_DATA_10BIT -> RAW_DATA_12BIT (IMX385 native) (mipi) +wdr_type = DOL Isp_FrameRate 25 -> 60 DevRect_x/y 4 -> 0 DllFile remains libsns_imx385.so (generic, loaded from the standard sensor library path). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix IMX385 sensor bring-up on hi3519v101 by (1) matching the sensor ini to the driver's exported symbol and real-hardware values, and (2) building the sensor `libsns_imx385.so` from openhisilicon source instead of shipping a prebuilt blob — the same pattern hi3516ev200 / gk7205v200 / hi3516cv500 already use.
Commits
1. `hisilicon-osdrv-hi3519v101`: fix IMX385 sensor config for real hardware
Default `imx385_i2c_1080p.ini` ships values that don't produce a working image on a real IMX385 rig (Hi3516AV200 DEMO, 4-lane MIPI, 1080p60 linear):
2. `hisilicon-opensdk`: build IMX385 sensor from source for hi3519v101
Add hi3519v101 to the same opensdk-builds-sensor-from-source pattern used by hi3516ev200 / gk7205v200 / hi3516cv500:
The source already exists at `openhisilicon/libraries/sensor/hi3519v101/sony_imx385/` in the commit tracked by `HISILICON_OPENSDK_VERSION` (8889317). No version bump needed.
No binary blobs added to the tree. The libsns_imx385.so at `files/sensor/` remains as fallback for builds that don't enable opensdk.
Test
Verified end-to-end on a Hi3516AV200 DEMO board (hi3519v101 SDK) running OpenIPC firmware with IMX385 + fixed lens (no iris). Side-by-side, same scene:
🤖 Generated with Claude Code