hi3516av100/dv100: ship + load the VDA kernel module (enable HW motion detection)#2197
Merged
Conversation
The Hi3516A/D V100 (hi3516av100/hi3516dv100) firmware shipped the VDA userspace API (libmpi exports HI_MPI_VDA_*) but not the VDA kernel driver: hi3516a_vda.ko exists in files/kmod/ but its install was commented out, and load_hisilicon never insmod'd it. So /proc/umap/vda was absent and any HI_MPI_VDA_* call (e.g. hardware motion detection) failed at runtime. - .mk: install hi3516a_vda.ko to the target. - load_hisilicon: insmod hi3516a_vda.ko (after the encoders) and rmmod it on teardown, for the hi3516av100/hi3516dv100 module set. Verified on hi3516dv100: with the module loaded, /proc/umap/vda appears and majestic's VDA motion detection runs end-to-end (960x528 MD, object boxes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Hi3516A/D V100 (
hi3516av100/hi3516dv100) the firmware shipped the VDA userspace API —libmpiexportsHI_MPI_VDA_*— but not the VDA kernel driver:hi3516a_vda.kois present infiles/kmod/but its$(INSTALL)line was commented out, so it never reached the rootfs.load_hisilicon(the loader run at boot viaS70vendor → load_$(ipcinfo -v) -i) had noinsmod hi3516a_vda.ko.Result: no
/proc/umap/vda, so anyHI_MPI_VDA_*call fails — in particular majestic's hardware motion detection (the VDA backend used for Gen1/Gen2 HiSilicon) can't start on these SoCs.Change
.mk: installhi3516a_vda.koto/lib/modules/4.9.37/hisilicon.load_hisilicon:insmod hi3516a_vda.koafter the encoders, andrmmod -w hi3516a_vdaon teardown.No userspace changes — the VDA API and the consuming app code already exist.
Validation
On a
hi3516dv100board: after loading the module,/proc/umap/vdaappears andhi3516a_vdashows inlsmodalongside the rest of the MPP stack. majestic's VDA motion detection then runs end-to-end —HI_MPI_VDA_CreateChnsucceeds, 960×528 MD frame, object bounding boxes, with localized detections tracking real motion. No regression to the other modules (VDA loads next to the streaming stack).🤖 Generated with Claude Code