poppler: update to 24.11.0; fix the tests #19512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtelka
reviewed
Nov 10, 2024
| include $(WS_MAKE_RULES)/common.mk | ||
|
|
||
| PATH= $(QT5_BINDIR):$(PATH.gnu) | ||
| PKG_CONFIG_PATH= $(PKG_CONFIG_PATH.$(BITS)):$(QT5_PKG_CONFIG_PATH) | ||
| PKG_CONFIG_PATH += $(QT5_PKG_CONFIG_PATH) |
There was a problem hiding this comment.
I think PKG_CONFIG_PATH is not designed to work properly with +=. You probably should use PKG_CONFIG_PATH.prepend instead.
mtelka
reviewed
Nov 10, 2024
components/library/poppler/Makefile
Outdated
| CMAKE_OPTIONS += -DENABLE_QT6=OFF | ||
| CMAKE_OPTIONS += -DQt5Core_DIR=$(QT5_LIBDIR)/cmake/Qt5Core | ||
| CMAKE_OPTIONS += -DQt5Gui_DIR=$(QT5_LIBDIR)/cmake/Qt5Gui | ||
| CMAKE_OPTIONS += -DQt5Xml_DIR=$(QT5_LIBDIR)/cmake/Qt5Xml | ||
| CMAKE_OPTIONS += -DQt5Widgets_DIR=$(QT5_LIBDIR)/cmake/Qt5Widgets | ||
| CMAKE_OPTIONS += -DQt5Test_DIR=$(QT5_LIBDIR)/cmake/Qt5Test | ||
| CMAKE_OPTIONS += -DTESTDATADIR=$(COMPONENT_DIR)/$(COMPONENT_NAME_1)-$(GIT_COMMIT_ID_1) | ||
|
|
||
| # Note that most tests are brokenon OpenIndiana |
There was a problem hiding this comment.
BTW, how this comment aligns with the results-all.master with the following results?
100% tests passed, 0 tests failed out of 65
AndWac
force-pushed
the
libpoppler-24.11.0
branch
from
6eeb680
to
8c3e63b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.