Fix pre-commit linter #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheavy
force-pushed
the
fix/precommit-linter
branch
from
a5a791f to
5d8757b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208.
Problem
Ruff linting not linting what should be linted (
softwaredirectory).Solution
Add actual
softwaredirectory to the list in the pre-commitruffconfig.Tested on
Discussion
This PR, albeit necessary for smoother collaboration, generates a lot of diff in many files—the actual linting.
Therefore, it has been broken into two distinct commits. This will facilitate review (only the first commit is actually proceeding with fixing the pre-commit issue) and should help any regression investigation via
git bisect, if ever needed.Tests from the Tested on section also include actually running the CLI simulator to ensure there were no regression.