test: Broaden regex to ignore copyright header file created by setupt… #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools Signed-off-by: Charles Moore <[email protected]>
|
epmog
approved these changes
Feb 26, 2025
AWS-Samuel
approved these changes
Feb 26, 2025
jblagden
pushed a commit
to jblagden/openjd-adaptor-runtime-for-python
that referenced
this pull request
Aug 21, 2025
…ools (OpenJobDescription#186) Signed-off-by: Charles Moore <[email protected]> Signed-off-by: Justin Blagden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The test_copyright_headers is failing.
What was the solution? (How)
Files created by setuptools has the header # file generated by setuptools-scm vs # file generated by setuptools_scm caused the unit test to fail. Updated the ignore case.
What is the impact of this change?
Tests pass
How was this change tested?
regex ignore change
Was this change documented?
N/A
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.