fix: Usage of __main__.py is not idiomatic #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Fixes: #143
What was the problem/requirement? (What/Why)
In https://docs.python.org/3/library/__main__.html#main-py-in-python-packages it says:
and later
In the last release, we updated
__main__.pyto be idiomatic, but missed that the pyproject.toml file required the script to be non-idiomatic.What was the solution? (How)
This fix corrects usage in pyproject.toml to be idiomatic.
What is the impact of this change?
Using the
openjdcommand should no longer run it twice.How was this change tested?
I ran
hatch buildto create a .whl. Installed that .whl into a virtual environment, and confirmed the resultingopenjdcommand worked as expected.Was this change documented?
N/A
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.