feat: Adding support for redacted environment variable values through… #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiebe
reviewed
Jun 5, 2025
baxeaz
force-pushed
the
mainline
branch
2 times, most recently
from
8212c42 to
5d6edf5
Compare
mwiebe
reviewed
Jun 5, 2025
src/openjd/cli/_run/_run_command.py
Outdated
| # Create a RevisionExtensions object with the default specification version and enabled extensions | ||
| # We use the default v2023_09 since that's what we're currently supporting | ||
| revision_extensions = RevisionExtensions( | ||
| spec_rev=SpecificationRevision.v2023_09, supported_extensions=extensions |
Contributor
There was a problem hiding this comment.
If this takes the spec rev from the_job instead of the constant, this code will be future-proof to when we publish the next revision.
Contributor
Author
There was a problem hiding this comment.
Discussed offline - I was looking at doing that exactly initially but it looked like Job didn't maintain revision - taking another look it's there on the base class. Will update!
… openjd_redacted_env Signed-off-by: Brian Axelson <[email protected]>
|
epmog
approved these changes
Jun 5, 2025
mwiebe
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We want to be able to test the new openjd_redacted_env feature in openjd-cli
We want to create openjd sessions using the new revision_extensions parameter
We want an openjd-cli test of the new openjd_redacted_env feature
What was the solution? (How)
Bump dependency versions
Update parameter to use revision_extensions
Add test
What is the impact of this change?
openjd-cli can use the latest version of openjd-sessions and model to test out features using extensions such as openjd_redacted_env.
How was this change tested?
Manual testing and hatch run test
Yes
Was this change documented?
Yes
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.