feat: Treat job template extensions other than .json as YAML #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `openjd run` and other commands will fail if the job template they receive has an extension different from .json, .yml, or .yaml. This change treats all non-.json extensions as YAML, so that job templates can be named with different extensions like `.ojdt` that clearly distinguish them from generic JSON or YAML. Signed-off-by: Mark <[email protected]>
|
jericht
approved these changes
Oct 27, 2025
miabatta
approved these changes
Oct 27, 2025
epmog
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Currently, the
openjd runand other commands will fail if the job template they receive has an extension different from .json, .yml, or .yaml. It would be nice to be able to use other file extensions as well.What was the solution? (How)
This change treats all non-.json extensions as YAML, so that job templates can be named with different extensions like
.ojdtthat clearly distinguish them from generic JSON or YAML.What is the impact of this change?
More flexible usage of the
openjdCLI.How was this change tested?
Ran
openjd runwith job templates that have a different extension than.yamlor.json. Saw that the failing cases now worked.Was this change documented?
No
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.