refactor: Adding default context values as ModelParsingContext for _m… #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odel classes inheriting from FormatString to simplify conversion/initialization Signed-off-by: Brian Axelson <[email protected]>
|
mwiebe
approved these changes
May 22, 2025
eherozhao
approved these changes
May 22, 2025
epmog
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Recent changes to FormatString to support and require a context made conversion and initialization of subclasses in _model overly verbose.
What was the solution? (How)
Add a default context to subclasses.
What is the impact of this change?
Simplify converting existing subclasses
How was this change tested?
openjd-sessions-for-python unit tests needed converting. Initially converting them required both the class constructor and the context initializer at every occurrence. Reconverted with this change and it significantly reduced the overhead. (Conversion PR is in a follow on)
Yes
Was this change documented?
NA
Is this a breaking change?
No, it's simplifying converting to support the previous change which was breaking.
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.