chore: change publish to pypi to use tag ref instead of release branch. #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Osiowy <[email protected]>
|
edwards-aws
approved these changes
Jul 3, 2025
miabatta
approved these changes
Jul 3, 2025
miabatta
pushed a commit
to miabatta/openjd-model-for-python
that referenced
this pull request
Sep 9, 2025
…h. (OpenJobDescription#211) Signed-off-by: Eric Osiowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The PublishToPyPI job was still pointing to the release branch. It should be looking at a tag now.
What was the solution? (How)
Change the reference to point to tag created during the PublishToPyPI job. It should be noted that the Publish job doesn't have an output anymore, so we need to use the output from TagRelease. (The other jobs in here also use the tag output from TagRelease).
What is the impact of this change?
Allow for PyPi releases./
How was this change tested?
N/A
Was this change documented?
No.
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.