test: cancel notify - message immediately after 'Trapped' may not be digit#294
Merged
epmog merged 1 commit intoOpenJobDescription:mainlinefrom Dec 31, 2025
Merged
Conversation
crowecawcaw
previously approved these changes
Dec 31, 2025
b1d5558 to
4ec872c
Compare
…digit Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
|
miabatta
approved these changes
Dec 31, 2025
crowecawcaw
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What was the problem/requirement? (What/Why)
Seen here: https://github.com/OpenJobDescription/openjd-sessions-for-python/actions/runs/20624606046/job/59232920551
The test expects that the message after "Trapped" is a digit, but this is time sensitive, so it's possible for the cancellation process to exit before the sleep process prints out the next number.
What was the solution? (How)
Change the assertions to check for digits any time before the targeted process exits
What is the impact of this change?
More robust tests
How was this change tested?
It's a timing issue, so I was unable to reproduce locally, but I ran
and confirmed it still passes locally.
Was this change documented?
N/A
Is this a breaking change?
N/A
Does this change impact security?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.