feat: add rolling-window withdrawal rate limit to treasury#336
Merged
OxDev-max merged 2 commits intoJun 28, 2026
Merged
Conversation
Protect treasury against single-key drain by introducing a per-24h rolling-window withdrawal cap. Both withdraw() and emergency_withdraw() now enforce the cap; the cap itself is protected by a 24 h timelock so it cannot be raised immediately after a compromise. - Add WithdrawalCap / EpochStart / EpochWithdrawn / WithdrawalCapProposal DataKey variants (and WithdrawalLock to fix pre-existing compile error) - Add EPOCH_DURATION = 86_400 s constant - enforce_rate_limit(): resets epoch counter after 24 h, rejects when EpochWithdrawn + amount > WithdrawalCap (cap = 0 means uncapped) - record_withdrawal(): persists running total for the current epoch - propose_withdrawal_cap() + execute_withdrawal_cap() (24 h timelock) - get_withdrawal_cap() view - Add WithdrawalRateLimitExceeded / WithdrawalCapTimelockNotElapsed / NoCapChangeProposed errors to KoraError - Add withdrawal_cap_proposed / withdrawal_cap_updated events Closes OpenLedger-Foundation#225
|
@Inkman007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect treasury against single-key drain by introducing a per-24h rolling-window withdrawal cap. Both withdraw() and emergency_withdraw() now enforce the cap; the cap itself is protected by a 24 h timelock so it cannot be raised immediately after a compromise.
Closes #225