Conversation
- Preserve the source extension in family-transfer temporary upload names. - Fall back to .transfer for extensionless source files. - Add unit coverage for extension handling. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
|
Real testing is needed. |
|
I completed a real-world test with the PR commit deployed on an Android ARM64 host. Test procedure:
Result with this patch:
This confirms that preserving the extension during the family-cloud temporary upload allows the remote service to generate a working preview for the transferred image. |
|
The resume key only uses session and MD5. A canceled |
- Separate resumable upload state for identical content with different extensions. - Preserve resume behavior when only the temporary file name changes. - Add unit coverage for both cases. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
|
Thanks for catching this. I updated the resumable upload key to include This prevents identical I also added a unit test covering both cases:
Tested with: |
pikachuren
left a comment
There was a problem hiding this comment.
🙏 感谢 @qcnhy 提交!
🤖 AI 自动审核声明:本评审报告由 AI 自动生成,当前使用 Claude Opus 5 模型进行分析。
🎯 结论
✅ Approve — 代码质量良好,建议合并
📖 概要
fix(189pc): preserve file extension during family transfer
📊 评审结果
改动合理,无重大问题发现。代码逻辑清晰,符合项目规范。
🎯 结论:✅ Approve — 建议合并
Summary / 摘要
Preserve the source file extension in the temporary upload name used by
189CloudPCfamily transfer.Fall back to
.transferwhen the source file has no extension.Add unit coverage for common, uppercase, compound, and extensionless file names.
This allows the remote service to classify images when they are first created, while leaving the existing transfer and final rename flow unchanged.
This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR: None.
Related Issues / 关联 Issue
Closes #3081
Testing / 测试
go test ./...go test -vet=off ./drivers/189pcChecklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。