fix(op): enforce link cache lifecycle policy - #3101
Merged
jyxjjj merged 2 commits intoSep 21, 2026
Merged
Conversation
- Share one admitted lifecycle policy between regular and archive links. - Reject and release links that combine TTL caching with owned resources. - Keep wrapper clones independent from the source cache expiration. - Cover reuse, reference, invalidation, conflict, and clone behavior. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
11 tasks
jyxjjj
approved these changes
Sep 19, 2026
pikachuren
reviewed
Sep 21, 2026
pikachuren
left a comment
Collaborator
There was a problem hiding this comment.
🙏 感谢 @nostalume 提交!
🤖 AI 自动审核声明:本评审报告由 AI 自动生成,当前使用 Claude Opus 5 模型进行分析。
🎯 结论
✅ Approve — 代码质量良好,建议合并
📖 概要
fix(op): enforce link cache lifecycle policy
📊 评审结果
改动合理,无重大问题发现。代码逻辑清晰,符合项目规范。
🎯 结论:✅ Approve — 建议合并
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
RequireReference, instead of leaving a close-sensitive value addressable until TTL expiry;Link.Clonetransfer ownership without copying the source cache expiration, which removes alias's local workaround and keeps chunk/strm wrapper links valid;Compatibility: valid TTL, reference-required, and close-invalidated modes keep their existing cache keys, TTLs, singleflight, retry, cancellation, and public return types. Drivers returning the previously ambiguous TTL-plus-owned-resource state now receive an explicit error; repository construction paths are normalized by the clone change.
/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Relates to #3098 (roadmap items 3-4).
This branch is based directly on
main@4580c4dband has no code dependency on #3090, #3095, or #3100.Testing / 测试
Platform: openSUSE Tumbleweed WSL, Go 1.27.1 linux/amd64.
go test ./...127.0.0.1:6800; and existing HTTP client initialization/transport assumptions.go test ./drivers/alias ./drivers/chunk ./drivers/crypt ./drivers/strm ./internal/op ./internal/model ./internal/fs ./internal/stream ./server/s3 ./server/handlesgo test -race ./internal/op ./internal/modelgo vet ./internal/op ./internal/model ./drivers/alias ./drivers/chunk ./drivers/crypt ./drivers/strmChecklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt./ 我已使用
gofmt格式化变更代码。/ 尚待人工确认后请求审核。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Tests / 测试
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 待人工审核确认。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含归属信息。
I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 待人工审核确认。