Skip to content

fix(op): enforce link cache lifecycle policy - #3101

Merged
jyxjjj merged 2 commits into
OpenListTeam:mainfrom
nostalume:refactor/acquired-link-policy
Sep 21, 2026
Merged

jyxjjj merged 2 commits into
OpenListTeam:mainfrom
nostalume:refactor/acquired-link-policy

Conversation

@nostalume

@nostalume nostalume commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary / 摘要

  • admit driver links into one cache lifecycle policy shared by regular links and archive extraction;
  • reject and release links that combine TTL caching with owned closers or RequireReference, instead of leaving a close-sensitive value addressable until TTL expiry;
  • make Link.Clone transfer ownership without copying the source cache expiration, which removes alias's local workaround and keeps chunk/strm wrapper links valid;
  • cover TTL reuse, reference-counted reuse/final close, close-invalidated reacquisition, rejected-resource cleanup, and clone ownership with behavior tests.

Compatibility: valid TTL, reference-required, and close-invalidated modes keep their existing cache keys, TTLs, singleflight, retry, cancellation, and public return types. Drivers returning the previously ambiguous TTL-plus-owned-resource state now receive an explicit error; repository construction paths are normalized by the clone change.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend: N/A
  • OpenList-Docs: N/A

Related Issues / 关联 Issue

Relates to #3098 (roadmap items 3-4).

This branch is based directly on main@4580c4db and has no code dependency on #3090, #3095, or #3100.

Testing / 测试

Platform: openSUSE Tumbleweed WSL, Go 1.27.1 linux/amd64.

  • go test ./...
    • Attempted. Unrelated existing failures remain in untouched packages: Go 1.27 non-constant-format vet diagnostics; tests requiring local aria2 on 127.0.0.1:6800; and existing HTTP client initialization/transport assumptions.
  • Focused tests:
    • go test ./drivers/alias ./drivers/chunk ./drivers/crypt ./drivers/strm ./internal/op ./internal/model ./internal/fs ./internal/stream ./server/s3 ./server/handles
    • go test -race ./internal/op ./internal/model
    • go vet ./internal/op ./internal/model ./drivers/alias ./drivers/chunk ./drivers/crypt ./drivers/strm
  • Manual test / 手动测试: Not run; this change is exercised at the cache/resource boundary.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING。
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt.
    / 我已使用 gofmt 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 尚待人工确认后请求审核。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • Codex

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Tests / 测试

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 待人工审核确认。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 待人工审核确认。

- Share one admitted lifecycle policy between regular and archive links.
- Reject and release links that combine TTL caching with owned resources.
- Keep wrapper clones independent from the source cache expiration.
- Cover reuse, reference, invalidation, conflict, and clone behavior.

Co-authored-by: Codex <267193182+codex@users.noreply.github.com>

@pikachuren pikachuren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 感谢 @nostalume 提交!
🤖 AI 自动审核声明:本评审报告由 AI 自动生成,当前使用 Claude Opus 5 模型进行分析。
⚠️ AI 分析结果仅供参考,可能存在误判或遗漏。如您发现任何问题或有不同意见,欢迎随时提出讨论和纠正。
⚠️ 重要提醒:即使 AI 评审认为代码质量良好且建议合并,最终是否合并仍需由项目维护者进行人工判定。项目维护者会综合考虑代码质量、项目规划、技术方向、团队资源等多方面因素做出是否合并的决策。

🎯 结论

✅ Approve — 代码质量良好,建议合并

📖 概要

fix(op): enforce link cache lifecycle policy

📊 评审结果

改动合理,无重大问题发现。代码逻辑清晰,符合项目规范。

🎯 结论:✅ Approve — 建议合并

@jyxjjj
jyxjjj merged commit 56064d1 into OpenListTeam:main Sep 21, 2026
12 checks passed
@nostalume
nostalume deleted the refactor/acquired-link-policy branch September 21, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants