Conversation
- Return isolated link borrowers from regular and archive caches while removing duplicate lifecycle policy. - Transfer link cleanup to proxy and seekable-stream consumers, with bodies released before links. - Remove redundant wrappers and caller-side cleanup across alias, chunk, strm, and transfer paths. - Cover cache isolation, stream close order, proxy range behavior, and proxy cleanup. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
nostalume
marked this pull request as ready for review
September 24, 2026 11:53
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Consolidate Domain 1 link acquisition and terminal ownership: cache entries return isolated borrowers, while proxy and seekable-stream consumers own link cleanup.
Release range bodies before their links, including chunk reads; remove the duplicate lifecycle-policy file,
ProxyRange, redundant link wrappers, and caller-side cleanup.Preserve range/HEAD behavior and cached descriptor isolation with behavior tests. Relative to
893457cd, production Go code is net -23 lines and tests are net +112 lines.Compatibility: the exported
server/common.Proxyfunction now takes aproxyRange boolargument. All in-repository callers are updated; external Go callers of this function must pass the new argument. No config or storage-format migration is required.This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR: None known.
Related Issues / 关联 Issue
Relates to #3098.
Testing / 测试
go test ./...— run on Windows with Go 1.27.1, but not passing. The same upstream base also fails in the same categories: pre-existing dynamic-format vet errors and environment-sensitive package tests (onedrive_sharelink,multipart,internal/net,aria2/rpc,server/mcp). This PR does not claim a green full suite.go build ./...and fresh focusedgo test -count=1for the changed packages (internal/model,internal/op,internal/stream,internal/fs,internal/offline_download/tool,server/common,server/handles,server/webdav,server/ftp,drivers/alias,drivers/chunk,drivers/crypt,drivers/strm).go test -race -count=1 ./internal/op ./internal/stream ./server/common ./drivers/chunk ./drivers/strm(the chunk package currently has no tests).git diff --check, committed-filegofmtcheck, and Git connectivityfsckpassed.Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况格式化变更代码。
/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中包含的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含归属信息。
I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。
This draft remains pending the contributor's own review and policy attestations; the unchecked boxes are intentional.