Conversation
- Remove unconditional unsupported mutation and archive-decompress methods from 16 drivers. - Let operation dispatch represent unavailable capabilities through interface absence without adding a compatibility layer. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
- Share the AList V3 and OpenList protocol mechanism while retaining product shells and dialects. - Replace duplicated implementation with focused family behavior and dialect tests. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
- Check operation-level NotImplement behavior for unavailable copy and archive capabilities. - Exercise shared AList/OpenList link forwarding and cache-key context through both product shells. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
- Replace distributed init registration and blank-import activation with one atomic 93-product catalog installed at startup. - Keep product constructors and metadata local, remove catalog residue, and adapt tests to explicit installation. - Reject invalid catalog inputs without replacing the installed product set. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Replace Driver
initself-registration and blank-import activation with one explicit 93-product constructor catalog installed before command execution. Preserve the baseline product names and persisted configuration schemas; reject nil or duplicate constructors without replacing the installed catalog.Remove
op.RegisterDriverand changedrivers.Allto return constructors. This is a source-compatibility change for downstream forks or Driver integrations that use the old registration path; no storage-format migration is intended.Depends on refactor(drivers)!: remove false capabilities and share OpenList protocol #3133. This branch contains refactor(drivers)!: remove false capabilities and share OpenList protocol #3133's commits plus one catalog commit. Until refactor(drivers)!: remove false capabilities and share OpenList protocol #3133 lands, the upstream PR's default diff includes that predecessor. Review only this catalog layer. Please review in parallel, but merge after refactor(drivers)!: remove false capabilities and share OpenList protocol #3133. Once refactor(drivers)!: remove false capabilities and share OpenList protocol #3133 lands, we will update this same PR branch against landed
mainand rerun the final checks; no replacement PR is planned.This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR: None known.
Related Issues / 关联 Issue
Relates to #3098.
Testing / 测试
Windows, Go 1.27.1, catalog head
47496d7a:go test ./internal/op ./server/handles ./server/s3 ./drivers/github ./drivers/alist_v3 ./drivers/openlist— passed.go veton the same six packages — passed.go build ./...— exited successfully; Go printed a non-fatal module stat-cache access warning in this restricted environment.All 97 changed committed Go blobs are gofmt-clean;
git diff --checkpassed. There are no remaining DriverRegisterDrivercalls or blank Driver imports.Earlier candidate verification also passed WSL race tests for
internal/op,server/handles,server/s3, and GitHub Driver. This was not rerun after this publication audit.Full
go test ./...is not claimed green: earlier Windows runs failed in dynamic-format vet and environment-sensitive categories also present on the unchanged upstream baseline. It was not rerun in this audit.go test ./...Manual test / 手动测试:
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。