fix(google_drive): use errors.New for token error strings - #3138
Closed
mythic3011 wants to merge 2 commits into
Closed
mythic3011 wants to merge 2 commits into
mythic3011 wants to merge 2 commits into
Conversation
go vet flags fmt.Errorf(e.Error) as a non-constant format string. Use errors.New when no formatting is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two
go vetfailures indrivers/google_drive/util.gocaused byfmt.Errorf(e.Error).Replaces them with
errors.New(e.Error)(no formatting required). No changes to token-refresh logic.Separate from any Google Workspace export work.
Test plan
go test ./drivers/google_drive/...