Remove obsolete Cython version check in test_enums #206
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: timosachsenberg <[email protected]>
Copilot
AI
changed the title
[WIP] Update codebase for Cython 3 and Python 3.9 compatibility
Remove obsolete Cython version check in test_enums
Nov 28, 2025
Copilot finished work on behalf of
timosachsenberg
November 28, 2025 12:21
timosachsenberg
added a commit
that referenced
this pull request
Nov 28, 2025
* update install instructions * Update TODO for current roadmap * Migrate to Cython 3 only * Remove workflow file changes * Remove MIGRATION_PLAN.MD (#203) * Initial plan * Remove MIGRATION_PLAN.MD as requested Co-authored-by: timosachsenberg <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: timosachsenberg <[email protected]> * Update CI matrix to remove old Cython versions Removed incompatible Cython and Python version combinations. * Remove obsolete Cython version check in test_enums (#206) * Initial plan * Remove obsolete Cython version check in test_enums Co-authored-by: timosachsenberg <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: timosachsenberg <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Samuel Wein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
NameError: name 'cython_version' is not definedintest_enums. The import was removed in the Cython 3 migration but a merge from PR #131 reintroduced the version check without the import.if int(cython_version[0]) < 3: returnguard since the codebase exclusively targets Cython 3+💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.