-
Notifications
You must be signed in to change notification settings - Fork 22
Enhance error messages for libsvm build process #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated error messages to include build error details.
WalkthroughUpdates libSVM CMake build script to append Changes
Sequence Diagram(s)sequenceDiagram
actor Dev as Developer
participant CM as CMake (libsvm.cmake)
participant CFG as Configure Step
participant BLD as Build Step (Debug/Release)
participant EH as Error Handler
Dev->>CM: Invoke libSVM build
CM->>CFG: Configure
alt Configure fails
CFG-->>EH: Set LIBSVM_CMAKE_ERR / LIBSVM_BUILD_ERR
EH-->>Dev: FATAL_ERROR "Generating ... failed:\n${...}"
else Configure succeeds
CM->>BLD: Build (MSVC / non-MSVC)
alt Build fails
BLD-->>EH: Set LIBSVM_BUILD_ERR
EH-->>Dev: FATAL_ERROR "Building ... failed:\n${LIBSVM_BUILD_ERR}"
else Build succeeds
CM-->>Dev: Build complete
end
end
note right of EH: All FATAL_ERROR paths now append the error payload\nOne path includes a leading blank line before the payload
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libraries.cmake/libsvm.cmake(5 hunks)
🔇 Additional comments (2)
libraries.cmake/libsvm.cmake (2)
65-65: LGTM!The error messages correctly reference
LIBSVM_BUILD_ERR, which matches the error variable captured during the respective build steps (lines 57 and 75).Also applies to: 82-82
136-136: LGTM!The error message correctly references
LIBSVM_BUILD_ERR, which matches the error variable captured during the build step (line 129).
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Updated error messages to include build error details.
Summary by CodeRabbit
Bug Fixes
Chores