Skip to content

Conversation

@poshul
Copy link
Contributor

@poshul poshul commented Oct 15, 2025

Updated error messages to include build error details.

Summary by CodeRabbit

  • Bug Fixes

    • Improved build-time error messages for the machine learning component: configure and Debug/Release build failures now include the underlying error output to make diagnostics clearer.
  • Chores

    • Standardized fatal error message text and spacing for more readable build logs; a minor formatting adjustment adds an extra blank line in one error path.

Updated error messages to include build error details.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Walkthrough

Updates libSVM CMake build script to append LIBSVM_CMAKE_ERR / LIBSVM_BUILD_ERR details to FATAL_ERROR messages for configure and build failures across MSVC and non‑MSVC branches; introduces an explicit blank line before the appended error in one path.

Changes

Cohort / File(s) Summary
libSVM build error messaging
libraries.cmake/libsvm.cmake
Standardizes FATAL_ERROR messages to append corresponding LIBSVM_CMAKE_ERR / LIBSVM_BUILD_ERR payloads for configure and build failures across MSVC and non‑MSVC branches (Debug/Release, macOS/non‑macOS). Adds an explicit blank line before the appended error in one path.

Sequence Diagram(s)

sequenceDiagram
    actor Dev as Developer
    participant CM as CMake (libsvm.cmake)
    participant CFG as Configure Step
    participant BLD as Build Step (Debug/Release)
    participant EH as Error Handler

    Dev->>CM: Invoke libSVM build
    CM->>CFG: Configure
    alt Configure fails
        CFG-->>EH: Set LIBSVM_CMAKE_ERR / LIBSVM_BUILD_ERR
        EH-->>Dev: FATAL_ERROR "Generating ... failed:\n${...}"
    else Configure succeeds
        CM->>BLD: Build (MSVC / non-MSVC)
        alt Build fails
            BLD-->>EH: Set LIBSVM_BUILD_ERR
            EH-->>Dev: FATAL_ERROR "Building ... failed:\n${LIBSVM_BUILD_ERR}"
        else Build succeeds
            CM-->>Dev: Build complete
        end
    end

    note right of EH: All FATAL_ERROR paths now append the error payload\nOne path includes a leading blank line before the payload
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hopped through CMake’s burrowed maze,
Now errors speak in clearer phrase—
LIBSVM whispers what went wrong,
A newline hums before the song.
This rabbit nods, then hops along. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the main change by indicating that error messages in the libsvm build process have been improved to include additional details, so it accurately reflects the pull request’s intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch poshul-patch-2-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bea5fb9 and e2f50e3.

📒 Files selected for processing (1)
  • libraries.cmake/libsvm.cmake (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • libraries.cmake/libsvm.cmake
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build (windows-latest)
  • GitHub Check: build (macos-latest)
  • GitHub Check: build (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6fde7c and d95847e.

📒 Files selected for processing (1)
  • libraries.cmake/libsvm.cmake (5 hunks)
🔇 Additional comments (2)
libraries.cmake/libsvm.cmake (2)

65-65: LGTM!

The error messages correctly reference LIBSVM_BUILD_ERR, which matches the error variable captured during the respective build steps (lines 57 and 75).

Also applies to: 82-82


136-136: LGTM!

The error message correctly references LIBSVM_BUILD_ERR, which matches the error variable captured during the build step (line 129).

poshul and others added 3 commits October 16, 2025 10:18
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@poshul poshul merged commit c0ce7fb into master Dec 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants